Task #56147

Epic #55070: Workpackages

Epic #54260: WP: FAL Missing Issues / Features / API

Story #54272: As an Editor I expect FAL to work with the RTE

Regenerate missing RTE magic image on rendering

Added by Fabien Udriot over 1 year ago. Updated 2 months ago.

Status:Needs Feedback Start date:2014-02-20
Priority:Should have Due date:
Assigned To:- % Done:

0%
Category:File Abstraction Layer (FAL) Spent time: 9.50 hours
Target version:-
TYPO3 Version:6.2 Complexity:medium
PHP Version: Sprint Focus:

Description

RTE now handles Magic images as Processed File and generate a new CSM image (Crop Scale Mask) upon "importation" in the RTE.

What is currently lacking is a way to regenerate this image in case the file is missing for instance after flushing the _processed_ directory.

It must be decided what is the best approach:

  • The image is regenerated on the fly when rendering the FE.
  • Via a scheduler task.
  • ...

Feedback welcome.

rte_custom_file_processing.zip (2.7 kB) Fabien Udriot, 2014-03-17 14:48

Related issues

related to Core - Feature #56133: Replace file feature for fal file list Resolved 2014-02-19
related to Core - Bug #56077: Blocking errors if files deleted Resolved 2014-02-18

History

#1 Updated by Fabien Udriot over 1 year ago

Regenerate Processed file...

Upon rendering
---------------

+ is transparent

- consume a more resources because it must be checked whether Processed File exists or not. (cache could compensate the cons)

Scheduler Task
---------------

+ does not take time from the rendering process

- must be configured and specifically created
- will not work well if the image is replaced

#2 Updated by Fabien Udriot over 1 year ago

As additional information, the processed file images are regenerated when the RTE is saved -> yes (and good). However this can not be the final solution IMHO because it forces the User to open up the content element and save it again. For big websites... well not the most adequate.

#3 Updated by Helmut Hummel over 1 year ago

Fabien Udriot wrote:

Regenerate Processed file...

Upon rendering
---------------

+ is transparent

- consume a more resources because it must be checked whether Processed File exists or not. (cache could compensate the cons)

This must be the way to go. ProcessedFiles already includes a caching layer and regenerates the file only if needed.

#4 Updated by Helmut Hummel over 1 year ago

  • Parent task set to #54272

#5 Updated by Fabien Udriot over 1 year ago

In case it is not clear enough, a small step-by-step procedure for reproducing the issue (it does not hurt):

1. Insert a Magic Image in the RTE
2. Look how nicely it is rendered on the FE
3. Delete the image in _processed_ directory
4. Reload the FE. Oh, a 404 image!

#6 Updated by Stanislas Rolland over 1 year ago

  • Assigned To set to Stanislas Rolland

#7 Updated by Stanislas Rolland over 1 year ago

  • Subject changed from RTE - regenerate Processed File if missing to Regenerate missing RTE magic image on rendering

#8 Updated by Stanislas Rolland over 1 year ago

  • % Done changed from 0 to 90

#9 Updated by Stanislas Rolland over 1 year ago

  • Status changed from New to Under Review

#10 Updated by Fabien Udriot over 1 year ago

There could be 3 tests to lead for testing and verifying the patch. Open a Text Content Element.

1. External Image

Copy / paste in body text:

Flag RTE disable: "on" 

<img src="http://government.typo3cms.demo.typo3.org/fileadmin/_processed_/csm_IMG_1400_7d600da0db.jpg" title="2012-05-29_13.43.19-1.jpg" width="265" height="177" alt="baz" style="foo: bar" class="foo"/>

2. MagicImage

-> Insert the image with the MagickImage wizard which is the default use case

#12 Updated by Stanislas Rolland over 1 year ago

  • % Done changed from 90 to 100

#13 Updated by Wouter Wolters over 1 year ago

  • Status changed from Under Review to Resolved

#14 Updated by Martin R. Krause 3 months ago

What actually has happend to this issues? It only says resolved but not if anything has changed.

I still have this issues with a current 6.2.12 version.

  1. Add a magic image,
  2. then change the image on the storage,
  3. let the scheduler task for indexing the storage notice the change.
  4. As a result the processed image is deleted, but calling the page does not generate a new image.

Any updates on that?

#15 Updated by Markus Klein 3 months ago

  • Status changed from Resolved to Accepted
  • Assigned To deleted (Stanislas Rolland)
  • Target version changed from 6.2.0 to next-patchlevel
  • % Done changed from 100 to 0
  • Complexity set to medium

I remember now having had a similar issue.
If a processed file is deleted, it is not properly regenerated for some reason.

Easily reproducable by setting config.noScaleUp = 0 in TS.
This triggers FAL to throw away (due to config change; more details in #66614) an existing processed file (from preview in RTE) when generating the image for FE, but the file is never regenerated.

#16 Updated by Markus Klein 2 months ago

  • Status changed from Accepted to Needs Feedback
  • Target version deleted (next-patchlevel)

In conjunction with with #66614 I know discovered that the RTE Click-Enlarge rendering (the static template) is buggy somehow.
Removing the static template, fixes the issue in FE and the proper image is generated.

I'm not sure, hence, how this is related to this ticket.

#17 Updated by Markus Klein 2 months ago

For the record: The click-enlarge functionality is ok.

Also available in: Atom PDF