CoreCommunity ExtensionsDistributionsFeature-RequestsTYPO3 6.2 Projects (+)(Archived Projects)

Bug #56153

6.2 Compatibility Changes

Added by Sebastian Stelmasik over 1 year ago. Updated 12 months ago.

Status:Closed Start date:2014-02-20
Priority:Should have Due date:
Assigned To:Sebastian Stelmasik % Done:

100%
Category:-
Target version:1.6.0

Description

Extansion causes lots of PHP Fatal error: require_once() issues.
Tried with patch provided here:

http://forge.typo3.org/issues/45943

But it does not solve all issues - created an updated one and attached it :).

Design is still corrupted, but extansion is fully functional.

feeditadvanced_patch_6.2 (5.1 kB) Sebastian Stelmasik, 2014-02-20 16:17

PageRenderer.php_patch (1000 Bytes) Sebastian Stelmasik, 2014-04-23 14:53

ajax.php Magnifier (30.5 kB) Hercules Karvasonis, 2014-05-26 15:05

class.tx_feeditadvanced_editpanel.diff Magnifier (1.1 kB) Hercules Karvasonis, 2014-06-16 14:53

feeditadvanced_patch_6.2_v2 (2.3 kB) Chris topher, 2014-08-03 16:29

Hercules_patch_ajax.php_v2.patch Magnifier (2.8 kB) Chris topher, 2014-08-03 17:59

Related issues

related to Advanced Frontend Editing - Bug #45943: 6.0 Compatibility Changes Closed 2013-03-01
related to Advanced Frontend Editing - Bug #60776: Stop using deprecated functions Closed 2014-08-04
precedes Advanced Frontend Editing - Bug #61212: Fix fatal error in TYPO3 < 6.2 Resolved 2014-08-26

Associated revisions

Revision c52513fb
Added by Chris topher about 1 year ago

[TASK] Remove require_once() calls to Core classes

Autoloader for Core classes is present since TYPO3 4.3. As far as
require_once() calls to core classes are concerned, these calls can be
removed.

Change-Id: If769e306552fe9b851048107ccc5218ed7dd08e2
Related: #56153
Reviewed-on: http://review.typo3.org/31958
Reviewed-by: Chris topher <>
Tested-by: Chris topher <>

Revision 6ad56aa0
Added by Chris topher about 1 year ago

[TASK] 6.2 Compatibility Changes

Fix inclusion of CSS and JS files as well as some language specific
settings.

Change-Id: Icbeb0173e340a24a793505ac3155d115f2c78d9a
Resolves: #56153
Reviewed-on: http://review.typo3.org/31961
Reviewed-by: Chris topher <>
Tested-by: Chris topher <>

History

#1 Updated by Chris topher over 1 year ago

Autoloader for Core classes is present since TYPO3 4.3. As far as require_once() calls to core classes are concerned, the solution is to just remove these calls.

#2 Updated by Sebastian Stelmasik over 1 year ago

  • File PageRenderer.php_patch added
  • Assigned To set to Sebastian Stelmasik
  • Target version set to 1.7.0
  • % Done changed from 0 to 90

Another error occured after updateing to 6.2.0/.1 (been using beta before) - PageRanderer lost charset/lang settings when cloned via ajax.
Updated Core-Page-Renderer (typo3/sysext/core/Classes/Page/PageRenderer.php) to fix (s. attachement). I ihink it's the same issue as here:

http://forge.typo3.org/issues/27957

#3 Updated by Hercules Karvasonis about 1 year ago

Hi Sebastian,

i tried to use the feeditadvanced extension on the latest TYPO3 6.2 and followed your instructions.
After i made the FE edit page to load i wasn't able to create new page, or new content or move an existing content.
The design was also corrupted as you mentioned above.

After digging into the code of the new TYPO3 i found out that TYPO3 is now caching all loaded ext_tables files and related conf files in typo3temp.
So, i used the "loadExtensionTables" function in "feeditadvanced/service/ajax.php" file in the initializeTSFE function right after the initializeBackendUser call.
This loaded correctly all conf files, the FE edit design is working correctly and i am able now to create new page, new content and move existing elements.

There were also a few js errors there since some js files are not included now and i fixed them also in the renderContentElement function.

I will continue digging and see if i find any other issues that need to be fixed for 6.2.

You check my code on the attached ajax.php file.

Thanks,
Hercules Karvasonis.

#4 Updated by Stefan Neufeind about 1 year ago

Could somebody wrap up the patches and submit them as a review to review.typo3.org (gerrit) please?

#5 Updated by Sebastian Stelmasik about 1 year ago

Hi Hercules (cool name :) ),

thanks for You commit - could you please provide a patch with everything that's different from the 'original' version, as I still have probs with the FE edit design.

Best regards,

Sebastian

#6 Updated by Hercules Karvasonis about 1 year ago

Hi Sebastian,

RTE is broken since there are a couple of CSS files not loaded on FE Edit with TYPO3 6.2

I have fixed the RTE issue by loading those 2 files.
You can find a diff file attached on this issue.

Thanks,
Hercules.

#7 Updated by Chris topher about 1 year ago

  • Target version changed from 1.7.0 to 1.6.0

#8 Updated by Chris topher about 1 year ago

I am currently trying to see, what changes are actually in the attached patches:

  • feeditadvanced_patch_6.2: Relevant from that patch is only the removal of require_once() calls in file service/ajax.php. Everything else has already been solved. New version attached. This change will be committed in https://review.typo3.org/31958/
  • The PageRenderer has been fixed with #27957. It now at least uses setCharSet() to set the charset. As for the language I am unsure - #27957 did not add a call to setLanguage().

To be continued with Hercules' post...

#9 Updated by Chris topher about 1 year ago

Attached is a cleaned-up version of Hercules' ajax.php file. I made a patch file out of it.

Also still have to deal with the design patch class.tx_feeditadvanced_editpanel, which Hercules attached above.

#10 Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project TYPO3CMS/Extensions/feeditadvanced has been pushed to the review server.
It is available at http://review.typo3.org/31961

#11 Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch master of project TYPO3CMS/Extensions/feeditadvanced has been pushed to the review server.
It is available at http://review.typo3.org/31961

#12 Updated by Gerrit Code Review about 1 year ago

Patch set 4 for branch master of project TYPO3CMS/Extensions/feeditadvanced has been pushed to the review server.
It is available at http://review.typo3.org/31961

#13 Updated by Gerrit Code Review about 1 year ago

Patch set 5 for branch master of project TYPO3CMS/Extensions/feeditadvanced has been pushed to the review server.
It is available at http://review.typo3.org/31961

#14 Updated by Chris topher about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 90 to 100

#15 Updated by Chris topher 12 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF