Bug #60776: Stop using deprecated functions - Advanced Frontend Editing - TYPO3 Forge

Core Community ExtensionsDistributions Feature-Requests TYPO3 6.2 Projects (+)(Archived Projects)

Bug #60776

Stop using deprecated functions

Added by Chris topher 12 months ago. Updated 12 months ago.

Status:

Closed

Start date:

2014-08-04

Priority:

Should have

Due date:

Assigned To:

Chris topher

% Done:

100%

Category:

Target version:

1.6.0

Description

Update usages of deprecated functions, e.g.:

$GLOBALS['LANG']->JScharCode() => GeneralUtility::quoteJSvalue() See here = #55009
FormEngine->isDisplayCondition() => Use \TYPO3\CMS\Backend\Form\ElementConditionMatcher instead. See #46461. Basically follow this code:
1 public function isDisplayCondition($displayCond, $row, $ffValueKey = '') { 2 GeneralUtility::logDeprecatedFunction(); 3 /** @var $elementConditionMatcher \TYPO3\CMS\Backend\Form\ElementConditionMatcher */ 4 $elementConditionMatcher = GeneralUtility::makeInstance('TYPO3\\CMS\\Backend\\Form\\ElementConditionMatcher'); 5 return $elementConditionMatcher->match($displayCond, $row, $ffValueKey); 6 }
includeTCA() =>
- set in a condition for 6.0 and older
- For 6.1 and newer:
  - If at the place where we would call includeTCA(), $GLOBALS['TCA']['pages'] is set: just leave out the call and do nothing.
  - Otherwise call \TYPO3\CMS\Frontend\Utility\EidUtility::initTCA(). See #47993.

Related issues

Associated revisions

Revision 6758b1f4
Added by Chris topher 12 months ago

[TASK] Stop using deprecated functions

Replace usages of the following functions with their new equivalent:

$GLOBALS['LANG']->JScharCode() => t3lib_div::quoteJSvalue()
FormEngine->isDisplayCondition() => ElementConditionMatcher->match()
Call $TSFE->includeTCA() only when needed

Change-Id: I636005214d8f42630aaa4681b070b43c13f2d29e
Resolves: #60776
Reviewed-on: http://review.typo3.org/31996
Reviewed-by: Chris topher <chrissitopher@gmx.de>
Tested-by: Chris topher <chrissitopher@gmx.de>

History

#1 Updated by Chris topher 12 months ago

Description updated (diff)

#2 Updated by Gerrit Code Review 12 months ago

Status changed from New to Under Review

Patch set 1 for branch master of project TYPO3CMS/Extensions/feeditadvanced has been pushed to the review server.
It is available at http://review.typo3.org/31996

#3 Updated by Chris topher 12 months ago

Status changed from Under Review to New

The patch solves all deprecations up to TYPO3 6.2.

One deprecation still remains on my system, but that is another issue:
Opening the edit window for a CE raises this warning multiple times:

The way registering a wizard in TCA has changed in 6.2. 
Please set module[name]=module_name instead of using script=path/to/sctipt.php in your TCA. 
The possibility to register wizards this way will be removed in 2 versions.

These warnings come from wizard_colorpicker.php, not the one coming with TYPO3, but from the one, which is coming with the extension bootstrap_package. The necessary changes (#56279) have already been done in https://github.com/benjaminkott/bootstrap_package/commit/d97a9d43701800d91e4a53f3367bcfcd46179b02 .