Bug #61699
Epic #58282: Workspaces Workpackage #2
Story #58284: Bug fixes & Behaviour
Workspace Preview not working with lockSSL=3
| Status: | Resolved | Start date: | 2014-09-18 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Oliver Hader | % Done: | 100% |
|
| Category: | Default | Spent time: | - | |
| Target version: | next-patchlevel | |||
| TYPO3 Version: | 6.2 | Is Regression: | Yes | |
| PHP Version: | 5.3 | Sprint Focus: | ||
| Complexity: | medium |
Description
The workspace preview does not work with lockSSL=3 being defined in the Install Tool. First it looks like a CSS issue, in the end it boils down that the preview IFRAMEs are not correctly initialized in \TYPO3\CMS\Workspaces\Hook\TypoScriptFrontendControllerHook. The mentioned hook is only called once for the request to the first IFRAME showing the website frontend preview and won't be called for further.
The reason is, that cache expire headers are sent that prevent the client to update the preview on each preview request. That's why the mentioned hook is not called and the IFRAMEs are not initialized properly. No-Cache headers are sent if a backend user object is initialized correctly - and that's the actual bug, a wrong but strict PHP condition, comparing a string (lockSSL) with an integer value.
The comparison flaw was integrated with issue #54265
Related issues
Associated revisions
[BUGFIX] Workspace Preview not working with lockSSL=3
The workspace preview does not work with lockSSL=3 being defined
in the Install Tool. First it looks like a CSS issue, in the end
it boils down that the preview IFRAMEs are not correctly
initialized in Workspaces\Hook\TypoScriptFrontendControllerHook.
The mentioned hook is only called once for the request to the
first IFRAME showing the website frontend preview and won't be
called for further.
The reason is, that cache expire headers are sent that prevent
the client to update the preview on each preview request.
That's why the mentioned hook is not called and the IFRAMEs
are not initialized properly. No-Cache headers are sent if a
backend user object is initialized correctly - and that's the
actual bug, a wrong but strict PHP condition, comparing a string
(lockSSL) with an integer value.
The comparison flaw was integrated with issue #54265
Change-Id: I13c5c2f22f5b43b49f8eead88f1bc82daf415cbb
Resolves: #61699
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/32851
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
[BUGFIX] Workspace Preview not working with lockSSL=3
The workspace preview does not work with lockSSL=3 being defined
in the Install Tool. First it looks like a CSS issue, in the end
it boils down that the preview IFRAMEs are not correctly
initialized in Workspaces\Hook\TypoScriptFrontendControllerHook.
The mentioned hook is only called once for the request to the
first IFRAME showing the website frontend preview and won't be
called for further.
The reason is, that cache expire headers are sent that prevent
the client to update the preview on each preview request.
That's why the mentioned hook is not called and the IFRAMEs
are not initialized properly. No-Cache headers are sent if a
backend user object is initialized correctly - and that's the
actual bug, a wrong but strict PHP condition, comparing a string
(lockSSL) with an integer value.
The comparison flaw was integrated with issue #54265
Change-Id: I13c5c2f22f5b43b49f8eead88f1bc82daf415cbb
Resolves: #61699
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/32857
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
History
#1 Updated by Gerrit Code Review 11 months ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32851
#2 Updated by Gerrit Code Review 11 months ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32857
#3 Updated by Oliver Hader 11 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset ede69ff629f4d5f8b7564831f36e8f04aa8508fc.
#4 Updated by Oliver Hader 11 months ago
- Parent task set to #58284
