Bug #65535

Exception: Serialization of 'Closure' is not allowed

Added by Stefan Froemken 5 months ago. Updated about 1 month ago.

Status:Under Review Start date:2015-03-05
Priority:Should have Due date:
Assigned To:Nicole Cordes % Done:

0%

Category:File Abstraction Layer (FAL) Spent time: -
Target version:7.4 (Backend)
TYPO3 Version:7 Is Regression:No
PHP Version:5.5 Sprint Focus:
Complexity:

Description

Hello,

I wanted to test following issue https://review.typo3.org/#/c/37483/
With contained TypoScript my TYPO3 master throws following Exception:

Exception: Serialization of 'Closure' is not allowed

The exception was thrown in last line of GifBuilder->fileName():

public function fileName($pre) {
    /** @var $basicFileFunctions \TYPO3\CMS\Core\Utility\File\BasicFileUtility */
    $basicFileFunctions = GeneralUtility::makeInstance('TYPO3\\CMS\\Core\\Utility\\File\\BasicFileUtility');
    $filePrefix = implode('_', array_merge($this->combinedTextStrings, $this->combinedFileNames));
    $filePrefix = $basicFileFunctions->cleanFileName($filePrefix);

    return $this->tempPath . $pre . $filePrefix . '_' . GeneralUtility::shortMD5(serialize($this->setup)) . '.' . $this->extension();
}

IMO the line 225 is the problem:

$this->setup[$theKey . '.']['BBOX'] = $fileInfo;

Here you fill in the complete FAL-System with all recursive/needed Objects. Again: We fill Objects into our lovely text-based TypoScript Array.

With following patch: https://review.typo3.org/#/c/37485/ the Exception will not appear anymore, but the problem is still there. The Objects are still there. After serializing this structure we have a nearly 100KB string which is needed ONLY to create a unique hash for a file.

Stefan


Related issues

related to Core - Bug #65378: Scaling/cropping images in GIFBUILDER does not work Resolved 2015-02-27
related to Core - Bug #65473: Remove closure in signalSlotDispatcher Resolved 2015-03-03
duplicated by Core - Bug #66124: Serialization of 'Closure' is not allowed in GifBuilder Closed 2015-03-29

History

#1 Updated by Gerrit Code Review 5 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37556

Also available in: Atom PDF