Bug #9210

imageViewHelper should not throw exception

Added by Felix Oertel almost 5 years ago. Updated over 3 years ago.

Status:Rejected Start date:2011-10-15
Priority:Won't have this time Due date:2011-10-15
Assigned To:- % Done:

0%

Category:ViewHelpers
Target version:-
Has patch: Affected Flow version:

Description

Hey guys,

i don't like the imageViewHelper to throw exceptions if an image is not found. it should behave like the underlying cObj::getImgResource() and just don't do anything.

regards, foertel

9210.diff Magnifier (676 Bytes) Felix Oertel, 2010-08-09 12:37


Related issues

related to TYPO3.Fluid - Feature #9211: Improve ViewHelper exception handling Rejected 2010-08-09
related to Core - Bug #61861: Frontend throws exception on missing image New 2014-09-24

History

#1 Updated by Felix Oertel almost 5 years ago

#2 Updated by Bastian Waidelich almost 5 years ago

  • Project changed from Extbase MVC Framework to TYPO3.Fluid
  • Target version deleted (Extbase 1.3.0beta1)

#3 Updated by Bastian Waidelich almost 5 years ago

  • Category set to ViewHelpers
  • Branch set to v4

#4 Updated by Felix Oertel almost 5 years ago

thanks a bunch ;-)

#5 Updated by Bastian Waidelich almost 5 years ago

  • Status changed from New to Rejected
  • Priority changed from Should have to Won't have this time

Currently all ViewHelper exceptions are catched and their message is outputted as string.
The corresponding code snippet in :

try {
    $output = call_user_func_array(array($viewHelper, 'render'), $renderMethodParameters);
} catch (Tx_Fluid_Core_ViewHelper_Exception $exception) {
        // @todo [BW] rethrow exception, log, ignore.. depending on the current context
    $output = $exception->getMessage();
}

As you can see, we're planing to improve the exception handling here. See #9211 for more details.

I'm closing this issue for now, feel free to reopen if you don't agree ;)

Also available in: Atom PDF