Bug #9304
Versioncheck for sprite manager is incorrect.
| Status: | Closed | Start date: | 2010-08-15 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assigned To: | Chris topher | % Done: | 100% |
|
| Category: | Editing Form | |||
| Target version: | 1.5.0 |
Description
I use TYPO3 4.4dev and feeditadvanced 1.4.
In localconf my compat_version is set to 4.4.
The test for instantiating the sprite manager requires a version number greater than 4004000 (translates to TYPO3_version greater than 4.4).
Sprites for TCEFORM are not displayed correctly out of the box in version 4.4.
If I change the test to >= the sprites are displayed correctly. * if(t3lib_div::int_from_ver(TYPO3_version) >= 4004000) {
// Load the sprite manager for frontend-editing
$spriteManager = t3lib_div::makeInstance('t3lib_SpriteManager', TRUE);
$spriteManager->loadCacheFile();
}*
As I understand the change logs, the sprite manager was introduced in versions starting with and greater than 4.4.
Related issues
Associated revisions
Fixed bug #9304: Versioncheck for sprite manager is incorrect.
git-svn-id: https://svn.typo3.org/TYPO3v4/CoreProjects/feedit/trunk@2836 743128fe-103e-dd11-99c4-001b210b3e58
History
#1 Updated by Chris topher almost 5 years ago
I think you are speaking of a development system (which is a valid reason to use a dev-version).
#2 Updated by Jeff Segars almost 5 years ago
- Status changed from New to Needs Feedback
- Target version set to 1.5.0
Hey Steve,
Thanks for the heads up on this. You're right that the check should definitely be greater than or equal to but there are a couple other points to clear up.
The compat_version doesn't actually come into play here at all since TYPO3_version is just the raw TYPO3 version. If you're having errors with the version comparison, I assume you're on a dev version prior to the actual 4.4 release? Trunk should now be 4.5.0-dev and the 4.4 branch should be 4.4.3-dev, both of which should work fine.
I'll get the bug fixed later today but in the meantime, can you confirm those version number details?
Thanks,
Jeff
#3 Updated by Steve Ryan almost 5 years ago
Jeff Segars wrote:
Hey Steve,
Thanks for the heads up on this. You're right that the check should definitely be greater than or equal to but there are a couple other points to clear up.The compat_version doesn't actually come into play here at all since TYPO3_version is just the raw TYPO3 version. If you're having errors with the version comparison, I assume you're on a dev version prior to the actual 4.4 release? Trunk should now be 4.5.0-dev and the 4.4 branch should be 4.4.3-dev, both of which should work fine.
I'll get the bug fixed later today but in the meantime, can you confirm those version number details?
Thanks,
Jeff
Hi Jeff,
I'm using a svn checkout
URL: https://svn.typo3.org/TYPO3v4/Core/branches/TYPO3_4-4
Repository Root: https://svn.typo3.org/TYPO3v4/Core
Repository UUID: 709f56b5-9817-0410-a4d7-c38de5d9e867
Revision: 8429
Afraid I am a bit blurry about trunk and dev versions from the repository. I thought that I understood that revision 8420 was marked for release as t4.4.0.
cheers
Steve
#4 Updated by Chris topher almost 5 years ago
The internal TYPO3 version in the 4.4-branch is currently 4.4.3-dev.
But with the old revision 8429 which you use you will still have it called "4.4-dev".
Here is an overview of the changes ("Updating version number to ..."):
http://forge.typo3.org/projects/typo3v4-core/repository/changes/branches/TYPO3_4-4/t3lib/config_default.php
I think you could work around that problem by updating the code from SVN. Just go on using the 4.4-branch and do an update.
#5 Updated by Chris topher over 4 years ago
- Subject changed from version check for sprite manager incorrect to version check for sprite manager is incorrect
#6 Updated by Chris topher over 4 years ago
Jeff Segars wrote:
You're right that the check should definitely be greater than or equal to(...).
Fixed in r2836.
#7 Updated by Chris topher over 4 years ago
- Subject changed from version check for sprite manager is incorrect to Versioncheck for sprite manager is incorrect.
- Status changed from Needs Feedback to Resolved
- Assigned To set to Chris topher
- % Done changed from 0 to 100
#8 Updated by Chris topher 12 months ago
- Status changed from Resolved to Closed